-
Notifications
You must be signed in to change notification settings - Fork 660
Show/hide modals when navigating with back/forward buttons #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using pushState and popState event handlers, we can understand when the modal needs to be closed (and prevents the browser from navigating away), and when the modal needs to be reopened (using the new modal:reopen event). By default this is turned off, but can be enabled in the modal options with `updateHistory: true`. Note that as this stands, this doesn't work very well with Turbolinks: I'm not sure yet if this is a bug on the Turbolinks side or not, but in the meantime, this behaviour works for non-Turbolinks sites.
(This PR doesn't update the minified versions, not sure how you do those)
There doesn't seem to be any way to prevent Turbolinks from reloading and replacing the entire browser window when a user clicks Back (since turbolinks:before-visit is not triggered for _when navigating by history_), So, rather than hiding the displayed modal when clicking Back (and then having to reload the page), we keep the Modal displayed while Turbolinks does its stuff in the background (including progress bar). See turbolinks/turbolinks#264 for a related issue (suggested `turbolinks:before-history-change` event).
Update: I don't think there's any way to handle Turbolinks + back button correctly, see turbolinks/turbolinks#264
@soundasleep Looks cool, and thanks for also updating the README 🙂
Would you mind adding an example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pushState and popState event handlers, we can understand when the
modal needs to be closed (and prevents the browser from navigating
away), and when the modal needs to be reopened (using the new modal:reopen
event).
By default this is turned off, but can be enabled in the modal options
with
updateHistory: true.Note that as this stands, this doesn't work very well with Turbolinks:
I'm not sure yet if this is a bug on the Turbolinks side or not, but in
the meantime, this behaviour works for non-Turbolinks sites.
May resolve #197