-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Conversation
Fix ESM import paths by adding .js extension to local imports
Fix error handling and integration tests
kunwarVivek
commented
Mar 10, 2025
Owner
It is showing conflicts with the current code.. can u pls resolve.
Author
Maybe next time, merge ongoing PR before pushing new code, especially when It's a fix to make your project work...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This pull request fixes several issues in the code:
Resolves the ESM import errors
-> Added the required .js extension to all local module imports. Since the project is configured as an ES module (type: module in package.json), explicit file extensions are required for local imports in the compiled JavaScript code.
This fixes the runtime error: ERR_MODULE_NOT_FOUND when trying to run the built application.
Error handling in GitHubIssueRepository:
-> Added a "GitHub API error:" prefix to error messages in the
createmethod to ensure consistency with GitHubProjectRepository.Integration tests in GitHubProjectManager.test.ts:
-> Configured Nock to allow connections to
api.github.com.-> Removed
scope.isDone()assertions that were no longer necessary.-> Added logs to debug pending mocks.
-> Modified the mocking approach to allow multiple calls to the same endpoints using
.persist().All tests now pass successfully.
Note that the code coverage remains below the required thresholds (80%), which may require future improvements.
Resolves #1