-
Notifications
You must be signed in to change notification settings - Fork 34
Open
Conversation
...(capitalization issue in MTKeyboardTab3.xib)
kellyroach
commented
Jul 13, 2018
Author
TEST: before restoring original Podfile
- 2 Analyze targets --> "No issues" PASSED
- Build and Run app on "iPhone X" simulator
Entered x/y+x^y >= 3.14159 and it looks OK
PASSED
TEST: after restoring original Podfile (current state of our P.R. branch)
- Analyze --> "3 warnings, 25 analyzer results"
which all seem to be from "Analyze target iosMath" as expected.
There is a good chance most or all of these will go away after next
release of iosMath to COCOAPODS.ORG, assuming it contains our
P.R. #103 on the iosMath repo changes. Without our changes in
current P.R. we will get "4 warnings, 28 analyzer results". - Build and Run app on "iPhone X" simulator
Entered x/y+x^y >= 3.14159 and it looks OK
PASSED
kellyroach
commented
Jul 13, 2018
Author
Product > Test before restoring original Podfile
Test Suite 'MTDisplayEditingTest' passed at 2018年07月12日 21:06:33.929.
Executed 5 tests, with 0 failures (0 unexpected) in 0.079 (0.082) seconds
Test Suite 'MathEditor_Tests.xctest' passed at 2018年07月12日 21:06:33.930.
Executed 5 tests, with 0 failures (0 unexpected) in 0.079 (0.083) seconds
Test Suite 'All tests' passed at 2018年07月12日 21:06:33.930.
Executed 5 tests, with 0 failures (0 unexpected) in 0.079 (0.085) seconds
Product > Test after restoring original Podfile
Test Suite 'MTDisplayEditingTest' passed at 2018年07月12日 21:09:18.971.
Executed 5 tests, with 0 failures (0 unexpected) in 0.057 (0.059) seconds
Test Suite 'MathEditor_Tests.xctest' passed at 2018年07月12日 21:09:18.972.
Executed 5 tests, with 0 failures (0 unexpected) in 0.057 (0.060) seconds
Test Suite 'All tests' passed at 2018年07月12日 21:09:18.973.
Executed 5 tests, with 0 failures (0 unexpected) in 0.057 (0.062) seconds
kellyroach
commented
Jul 13, 2018
Author
XCTOOL TEST ON OUR LOCALHOST
2015s-MacBook-Pro:MathEditor kellyroach$ xctool -workspace MathEditor.xcworkspace -scheme iosMathEditor-Example run-tests -test-sdk iphonesimulator
[Info] Loading settings for scheme 'iosMathEditor-Example' ... (733 ms)
=== RUN-TESTS ===
[Info] Collecting info for testables... (942 ms)
run-test MathEditor_Tests.xctest (iphonesimulator11.4, iPhone 5s, logic-test)
✓ -[MTDisplayEditingTest testClosestPointExponent] (16 ms)
✓ -[MTDisplayEditingTest testClosestPointFraction] (0 ms)
✓ -[MTDisplayEditingTest testClosestPointFractionPlusRegular] (0 ms)
✓ -[MTDisplayEditingTest testClosestPointRegular] (0 ms)
✓ -[MTDisplayEditingTest testClosestPointRegularPlusFraction] (0 ms)
5 passed, 0 failed, 0 errored, 5 total (19 ms)
** RUN-TESTS SUCCEEDED: 5 passed, 0 failed, 0 errored, 5 total **
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes assorted Xcode 9.4.1 compiler warnings.
This change extends support down to iOS 8.0 from iOS 9.2 and
avoids yellow warnings regarding 8.0 versus 9.2 linkage to iosMath .
Capitalization issue in MTKeyboardTab3.xib
Use Keyboard-marine-pressed with uppercase K .
We filtered iosMath Analyze issues by modifying Podfile at start of our
commit trail, then restoring original Podfile before we branched at end
of our commit trail. Our recently approved and merged P.R. #103 on
the iosMath repo addresses the iosMath Analyze issues not addressed
by the current P.R. here.
We tested MathEditor on our branch just before and just after restoring
original Podfile . The app functions OK in both tests. The difference is
we do see remaining iosMath Analyze issues after restoring original Podfile
because our P.R. #103 changes to the iosMath repo haven't been issued
a release on COCOAPODS.ORG yet.