Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Калентьев Илья tg: @m1nus0ne#248

Open
m1nus0ne wants to merge 2 commits into
kontur-courses:master from
m1nus0ne:master
Open

Калентьев Илья tg: @m1nus0ne #248
m1nus0ne wants to merge 2 commits into
kontur-courses:master from
m1nus0ne:master

Conversation

@m1nus0ne

@m1nus0ne m1nus0ne commented Nov 5, 2024

Copy link
Copy Markdown

No description provided.

Comment thread cs/HomeExercises/ObjectComparison.cs Outdated
new Person("Vasili III of Russia", 28, 170, 60, null));

// Какие недостатки у такого подхода?
//Проблема с читаемостью, необходимость обновлять метод AreEqual при изменении сигнатуры Person

@GarageManager GarageManager Nov 5, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А можешь в этом треде подробнее раскрыть, что ты имеешь в виду под читаемостью и под изменением сигнатуры?

@m1nus0ne m1nus0ne Nov 6, 2024

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При изменении/добавлении полей возникает необходимость переписывание метода AreEqual, сравнение ннго количества полей менне читаемое решение, чем сравнивание всех полей исключая поле Id ()

Comment thread cs/HomeExercises/NumberValidatorTests.cs Outdated
Comment thread cs/HomeExercises/NumberValidatorTests.cs Outdated
Comment thread cs/HomeExercises/NumberValidatorTests.cs Outdated
Comment thread cs/HomeExercises/NumberValidatorTests.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GarageManager GarageManager GarageManager requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /