Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Alexander Anronov @raccoon6996#237

Open
batyadmx wants to merge 4 commits into
kontur-courses:master from
batyadmx:master
Open

Alexander Anronov @raccoon6996 #237
batyadmx wants to merge 4 commits into
kontur-courses:master from
batyadmx:master

Conversation

@batyadmx

@batyadmx batyadmx commented Nov 28, 2023

Copy link
Copy Markdown

No description provided.

Comment on lines +15 to +31
[Test]
public void NumberValidator_WithNegativePrecision_ThrowsArgumentException()
{
Assert.Throws<ArgumentException>(() => new NumberValidator(-1, 2, true));
}

[Test]
public void NumberValidator_WithNegativeScale_ThrowsArgumentException()
{
Assert.Throws<ArgumentException>(() => new NumberValidator(2, -2, true));
}

[Test]
public void NumberValidator_WithScaleGreaterThanPrecision_ThrowsArgumentException()
{
Assert.Throws<ArgumentException>(() => new NumberValidator(2, 4, true));
}

@69raccoon96 69raccoon96 Nov 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше использовать TestCase, кстати, каждому кейсу можно задать свое имя с помощью TestName

[TestCase("1.0.1")]
public void IsValidNumber_WithIncorrectValue_ReturnFalse(string value)
{
Assert.False(new NumberValidator(10, 5).IsValidNumber(value));

@69raccoon96 69raccoon96 Nov 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Читается тяжело, можно разделить на инициализацию, вызов метода и проверку значения


Assert.False(validator.IsValidNumber(value));
}

@69raccoon96 69raccoon96 Nov 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Потерялся атрибут

Comment on lines +33 to +77
[TestCase(17, 2, true, "0.0")]
[TestCase(17, 2, true, "0")]
[TestCase(17, 2, true, "+0.0")]
[TestCase(3, 1, true, "+1.2")]
[TestCase(3, 1, false, "-1.2")]
public void IsValidNumber_WithProperValue_Success
(int precision, int scale, bool positive, string value)
{
var validator = new NumberValidator(precision, scale, positive);

Assert.True(validator.IsValidNumber(value));
}

[TestCase(" ")]
[TestCase("")]
[TestCase(null)]
[TestCase("+-1")]
[TestCase("abc")]
[TestCase("a.bc")]
[TestCase("1.0.1")]
public void IsValidNumber_WithIncorrectValue_ReturnFalse(string value)
{
Assert.False(new NumberValidator(10, 5).IsValidNumber(value));
}


[TestCase("-1.0")]
[TestCase("+1.0")]
[TestCase("10.0")]
[TestCase("1.00")]
public void IsValidNumber_WithValueGreaterThanPrecision_ReturnFalse(string value)
{
var validator = new NumberValidator(2, 1);

Assert.False(validator.IsValidNumber(value));
}

[TestCase(true, "1.00")]
[TestCase(false, "-1.00")]
public void IsValidNumber_WithFracPartGreaterThanScale_ReturnFalse(bool positive, string value)
{
var validator = new NumberValidator(10, 1, positive);

Assert.False(validator.IsValidNumber(value));
}

@69raccoon96 69raccoon96 Nov 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Честно говоря тут тоже ничего не мешает переделать все на тест кейсы

}
}

public class NumberValidator

@69raccoon96 69raccoon96 Nov 28, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вынести в отдельный файл. На шпоре, имхо, важно не только смотреть на то место, куда ты вносишь изменения но и на весь проект в целом, если видишь что где-то сделано не очень хорошо - исправляй. Так работает и в промышленной разработке (за исключением случаев, когда код написан настолько плохо, что трогать его страшно)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@69raccoon96 69raccoon96 69raccoon96 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /