-
Notifications
You must be signed in to change notification settings - Fork 0
Add experimental quicksort example#7
Open
kolt-mcb wants to merge 1 commit intocodex/add-benchmarks-for-large-sort from
Open
Add experimental quicksort example #7kolt-mcb wants to merge 1 commit intocodex/add-benchmarks-for-large-sort from
kolt-mcb wants to merge 1 commit intocodex/add-benchmarks-for-large-sort from
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Introduces a new experimental quicksort example in the Fraglets demo, updates documentation to include usage instructions, and removes a stray line from the existing selection sort file.
- Add
quicksort.frawith a recursive quicksort fraglet implementation - Document quicksort in
README.mdanddocs/INSTRUCTION_SET.md - Clean up leftover demo line in
sort.fra
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sort.fra | Removed trailing commented demo fragment |
| quicksort.fra | New file: experimental quicksort implementation |
| docs/INSTRUCTION_SET.md | Added "Experimental QuickSort" section |
| README.md | Added quicksort usage example and instructions |
Comments suppressed due to low confidence (3)
quicksort.fra:25
- [nitpick] State labels mix a
qs_prefix (e.g.qs_part) with unprefixed names likeless_sortandgreater_sort. Consider adding a consistentqs_prefix to these labels (e.g.qs_less_sort) to avoid collisions and improve readability.
[matchp less_sort match less qsort]
quicksort.fra:32
- The new quicksort example isn’t covered by any automated test. Adding a pytest case that runs
quicksort.frawith known inputs and verifies the sorted output would help catch future regressions.
[qsort 5 1 4 2 3]
docs/INSTRUCTION_SET.md:91
- [nitpick] The quicksort section describes the approach but doesn’t include a usage snippet. Consider adding a short fraglet invocation (e.g.
[qsort 3 1 2]) and expected result to illustrate how to run the example directly in this document.
## Experimental QuickSort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quicksort.fraas a new fraglets sorting demosort.fraTesting
pip install .pytest -qhttps://chatgpt.com/codex/tasks/task_e_687345cdf5fc83248d6a772a56f056e2