-
Notifications
You must be signed in to change notification settings - Fork 269
Fix LinkedList removeAt() #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1.added base case for removeAt(1) 2.switched assigment on line #138 where previous and current where pointing to the same node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @TheKingSombrero, thanks for the PR and it's good to see you took an interest. However, there are a few things that you have to see:
- ESLint rules should not break
- Remove methods should always return a node (and the next should be null)
- Please go through the issue details here: #83
- The removal method should work as an array
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No console.log() in the final push to master
passes eslint and matches and enforced strict equality for some reason it wasn't running in node with it
@rahulrana95
rahulrana95
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
@rahulrana95
rahulrana95
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return this.head from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!this.head) { this.head = node; this.tail = node; return node; }
If you do not make it null it will contain the full list
@rahulrana95
rahulrana95
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in linked list we don't keep size
@rahulrana95
rahulrana95
Oct 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better name
1.added base case for removeAt(1)
2.switched assigment on line #138 where previous and current where pointing to the same node