Search code, repositories, users, issues, pull requests...


 --update: find 2nd max in array

7c8a66f


 Merge branch 'master' of github.com:knaxus/problem-solving-javascript

2f8cd6f


 --fix: change syntax, naming and comments

50115f9

@ashokdey ashokdey requested a review from TheSTL

September 8, 2019 07:12

@ashokdey ashokdey assigned ashokdey and TheSTL

@ashokdey ashokdey added the enhancement label


 --fix : comment

5aab5cc

TheSTL

TheSTL reviewed

src/_Problems_/find-2nd-max/index.js Outdated

function findSecondMax(arr) {

let max = arr[0];

let max2 = 0;

Copy link

Member

@TheSTL TheSTL Sep 8, 2019 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialize max2 = -1.
If there are no Second Max then function should return -1.
Input : [1,1,1]
Output : -1

Copy link

Member Author

@ashokdey ashokdey Sep 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I find something better

let max2 = Number.MIN_SAFE_INTEGER;

TheSTL

TheSTL requested changes

Copy link

Member

@TheSTL TheSTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find-2nd-max
Changes required:

Initialize Max2 = -1;

TheSTL

TheSTL reviewed

src/_Problems_/find-2-nums-adding-to-n/index.js Outdated

}

return nums.length ? nums : false;

return pair.length ? pair : null;

Copy link

Member

@TheSTL TheSTL Sep 8, 2019 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return false if no pair found


 --update: max2 initialization, return false if no pair found

d1d0bd2

TheSTL

TheSTL approved these changes

@ashokdey ashokdey merged commit 181b1a6 into master