Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added test cases for BST deletion #66 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashokdey merged 2 commits into knaxus:master from balajipachai:test-cases-for-bst-deletion
Oct 17, 2019

Conversation

Copy link
Contributor

@balajipachai balajipachai commented Oct 11, 2019

Added test cases for BST deletion #66

Copy link
Member

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balajipachai please make the required changes.

Comment on lines +8 to +18
it('should create BST', () => {
// Creates BST
bst = new BinarySearchTree(6);
bst.add(4);
bst.add(9);
bst.add(2);
bst.add(5);
bst.add(8);
bst.add(12);
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@balajipachai how you are checking that the tree is created the way you wanted to create it? You have only added nodes, haven't verified that the nodes are added properly to the tee.

For that, you have to verify any of the traversal output.

Copy link
Contributor Author

I will look into it and update the PR

ashokdey reacted with thumbs up emoji

@ashokdey ashokdey changed the title (削除) Completed test cases for deletion (削除ここまで) (追記) Added test cases for BST deletion #66 (追記ここまで) Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokdey ashokdey ashokdey approved these changes

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /