Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Fibonacci problem for negative numbers #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheSTL merged 9 commits into knaxus:master from SumeetHaryani:master
Oct 10, 2019

Conversation

Copy link
Contributor

@SumeetHaryani SumeetHaryani commented Oct 8, 2019

Fix Fibonacci problem for negative numbers.
Fixes #42

Copy link
Member

@TheSTL TheSTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SumeetHaryani 👍

SumeetHaryani reacted with thumbs up emoji
Copy link
Contributor Author

Fixes #58

Copy link
Member

TheSTL commented Oct 10, 2019

Hey @SumeetHaryani .
Right now queue data is not implemented in right way.
I am opening a new issue for this. You can change reverse-first-k-elements-of-queue implementation after that.

SumeetHaryani reacted with thumbs up emoji

Copy link
Member

TheSTL commented Oct 10, 2019

@SumeetHaryani
If it's okay can you remove reverse-first-k-elements-of-queue implementation from this PR.
And when this issue #60 is fixed by @ashokdey you can create a new PR for your algo.

Copy link
Contributor Author

@TheSTL , I have removed reverse-first-k-elements-of-queue implementation from this PR.
Will add it once @ashokdey fixes the #60

@TheSTL TheSTL mentioned this pull request Oct 10, 2019
@TheSTL TheSTL merged commit 597cd0e into knaxus:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSTL TheSTL TheSTL approved these changes

@ashokdey ashokdey Awaiting requested review from ashokdey

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling fibonacci for negative numbers and 0

AltStyle によって変換されたページ (->オリジナル) /