Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

implement 2 stacks using 1 array #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ashokdey wants to merge 3 commits into master from problems
Closed

implement 2 stacks using 1 array #35

ashokdey wants to merge 3 commits into master from problems

Conversation

Copy link
Member

@ashokdey ashokdey commented Oct 6, 2019

🏖 What's inside?

So I went ahead to add a new problem in the Stack section.

  • The implementation is not regular because it does not deal with a fixed size array
  • I doubt that I may not have covered all the edge cases
  • In terms of optimization also, I feel there is a scope of improvement.

Copy link
Member Author

ashokdey commented Oct 6, 2019

Since insertions and deletions are going O(n) which is breaking the rules of Stack, this implementation is invalid.

@ashokdey ashokdey added the bug Something isn't working label Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSTL TheSTL Awaiting requested review from TheSTL

Labels
bug Something isn't working invalid This doesn't seem right new problem strict-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /