Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

add find-2nd-max tests #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashokdey merged 1 commit into knaxus:master from deadem:find-2nd-max-tests
Oct 4, 2019
Merged

add find-2nd-max tests #29

ashokdey merged 1 commit into knaxus:master from deadem:find-2nd-max-tests
Oct 4, 2019

Conversation

Copy link
Contributor

@deadem deadem commented Oct 4, 2019 •
edited
Loading

What's inside?

  • Add unit tests to Find second max problem
  • Export function to be used by test file

Copy link
Member

ashokdey commented Oct 4, 2019

Hello @deadem, good to see your PR. However, the PR details are missing, please have a look at #26 for more details. Once done, we can move to the review phase.

Copy link
Contributor Author

deadem commented Oct 4, 2019

Ow, there are no contribution guide, so I think it's unnecessary... Just updated the description.

Copy link
Member

ashokdey commented Oct 4, 2019

Ow, there are no contribution guide, so I think it's unnecessary... Just updated the description.

Well, there is an issue opened for creating the Contribution Guide, #18 🤝

@ashokdey ashokdey added under-review and removed invalid This doesn't seem right labels Oct 4, 2019
Copy link
Member

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 👍

@ashokdey ashokdey merged commit a434a3d into knaxus:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokdey ashokdey ashokdey approved these changes

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants

AltStyle によって変換されたページ (->オリジナル) /