Increase code coverage #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ashokdey merged 16 commits into master from codeCoverage

Oct 27, 2019

Merged

Increase code coverage #142

ashokdey merged 16 commits into master from codeCoverage

Oct 27, 2019

Conversation

TheSTL

Copy link

Member

@TheSTL TheSTL commented Oct 25, 2019 •

edited

Loading

🍰 What's Inside?

Fix eslint error.
Wrong file name corrected.
- src/DataStructures/Trees/BinarySearchTree/bst-deletion.test.js → src/DataStructures/Trees/BinarySearchTree/height-of-bst/height-of-bst.test.js
- src/DataStructures/Trees/BinarySearchTree/BinarySearchTree.test.js → src/DataStructures/Trees/BinarySearchTree/bst-remove.test.js
Add unit test for BST to increase code coverage.
- bst-search.test.js
- bst-minimum.test.js
- bst-maximum.test.js
- bst-isEmpty.test.js
Fix BST remove function. Earlier if we want to remove root and root has only one child then remove function not working correctly.
Increase code coverage for following algo to near 100 %
- TernarySearch
- JumpSearch
- get-smallest-common-number
- anagrams
- AStar
- lowest-common-ancestor
- height-of-bst
- postfix-expression-evaluation
- Queue
- LinkedList
Add Unit test case for DoublyLinkedList because code coverage is decreased when testing LRUCache testing which is implemented on DoublyLinkedList.
Create seprate file for Node of DoublyLinkedList

🎉 New Coverage will be 97% after merging.

TheSTL added 9 commits

October 25, 2019 15:59

@TheSTL


 --fix : eslint & coverage 100%

e3f3ff3

@TheSTL


 --fix : eslint & coverage 100% & return -1 if not found

ab84445

@TheSTL


 --fix : eslint & coverage 100%

05a97fc

@TheSTL


 --fix : coverage 100%

8fb5183

@TheSTL


 --fix : code coverage 100%

0e1038b

@TheSTL


 --fix : eslint error & variable declaration

601fd9f

@TheSTL


 --fix : BST remove function

b7ec098

@TheSTL


 --fix : eslint & code coverage 100%

9840f5e

@TheSTL


 --fix: eslint & increase code coverage near 100%

cf5637e

@TheSTL TheSTL requested a review from ashokdey

October 25, 2019 16:38

@TheSTL TheSTL self-assigned this

Oct 25, 2019

@TheSTL TheSTL added bug-fix enhancement Hacktoberfest strict-review labels

Oct 25, 2019

TheSTL added 5 commits

October 25, 2019 23:00

@TheSTL


 --fix : code coverage 100%

c8af420

@TheSTL


 --fix : code coverage near 100%

09e7441

@TheSTL


 --fix : code coverage 87%

da1729c

@TheSTL


 --update : seperate Node and DLL file

29bfb14

@TheSTL


 --update : add doublyLinkedList test

69c973a

@TheSTL TheSTL removed the under work label

Oct 25, 2019

@TheSTL TheSTL changed the title ~~(削除) Code coverage (削除ここまで)~~ (追記) Increase code coverage (追記ここまで)

Oct 26, 2019

ashokdey

ashokdey requested changes

Oct 26, 2019

View reviewed changes

Copy link

Member

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes, there are a lot but if you do it file by file that will be easy

src/_DataStructures_/DoublyLinkedList/doublyLinkedList.test.js

@@ -0,0 +1,40 @@

const DLL = require('.');

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for DLL should be a Class

src/_DataStructures_/Queue/Queue.test.js Outdated

expect(queue.dequeue()).toEqual(null);

});

it('Length of linkedlist', () => {

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Length of linkedlist' should be 'Size of Queue'

src/_DataStructures_/Queue/Queue.test.js Outdated

expect(queue2.length()).toEqual(4);

});

it('Destroy linkedList', () => {

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Destroy linkedList' should be 'Destroy Queue'

src/_DataStructures_/DoublyLinkedList/doublyLinkedList.test.js Outdated

describe('Doubly Linked List', () => {

const doublyLinkedList = new DLL();

it('create DLL', () => {

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'create DLL' -> 'It should create a DLL'

It's all about Behavior Driven Testing, hence it starts with or contains should

src/_DataStructures_/DoublyLinkedList/doublyLinkedList.test.js Outdated

expect(doublyLinkedList.length()).toEqual(0);

});

it('addAtBeginning', () => {

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change title

src/_DataStructures_/Trees/BinarySearchTree/lowest-common-ancestor/index.js

@@ -3,18 +3,15 @@

* Given values of two values n1 and n2 in a Binary Search Tree, find the Lowest Common Ancestor (LCA). You may assume that both the values exist in the tree.

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write a meaningful function name

src/_DataStructures_/Trees/BinarySearchTree/lowest-common-ancestor/index.js Outdated

function lca(node, n1, n2) {

if (node == null)

return null;

if (node == null) return null;

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ===

src/_DataStructures_/Trees/BinarySearchTree/lowest-common-ancestor/index.test.js

@@ -5,8 +5,7 @@ const BinarySearchTree = require('../index');

// {"left":{"left":{"data":4},"right":{"left":{"data":10},"right":{"data":14},"data":12},"data":8},"right":{"data":22},"data":20}

describe('LCA', () => {

let bst = new BinarySearchTree(20);

const bst = new BinarySearchTree(20);

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct all the titles

src/_DataStructures_/Trees/BinarySearchTree/bst-isEmpty.test.js Outdated

Comment on lines 6 to 11

bst.add(4);

bst.add(9);

bst.add(2);

bst.add(5);

bst.add(8);

bst.add(12);

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use loop here

src/_DataStructures_/Trees/BinarySearchTree/bst-isEmpty.test.js Outdated

Comment on lines 17 to 23

bst.remove(6);

bst.remove(4);

bst.remove(9);

bst.remove(2);

bst.remove(5);

bst.remove(8);

bst.remove(12);

Copy link

Member

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use loop here

@ashokdey ashokdey added changes-requested under-review unit-test-fix labels

Oct 26, 2019

TheSTL added 2 commits

October 26, 2019 21:33

@TheSTL


 --fix : unit test title & use loops to create BST

96ba2d3

@TheSTL


 --fix : fix lowestCommonAncestors import

980dcf9

@TheSTL

Copy link

Member Author

TheSTL commented Oct 26, 2019

Thanks @ashokdey . Please review the changes.

ashokdey

ashokdey approved these changes

Oct 27, 2019

View reviewed changes

Copy link

Member

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 🎉

@ashokdey ashokdey merged commit a37062e into master

Oct 27, 2019

@ashokdey ashokdey deleted the codeCoverage branch

October 27, 2019 05:26

Labels

bug-fix changes-requested enhancement strict-review under-review unit-test-fix

2 participants

@TheSTL @ashokdey

Increase code coverage #142

Increase code coverage #142

Uh oh!

Conversation

@TheSTL TheSTL commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

@ashokdey ashokdey Oct 26, 2019

Choose a reason for hiding this comment

Uh oh!

TheSTL commented Oct 26, 2019

Uh oh!

@ashokdey ashokdey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

@TheSTL TheSTL commented Oct 25, 2019 •

edited

Loading