-
Notifications
You must be signed in to change notification settings - Fork 269
Adding bottom view binary tree problem solution #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding bottom view binary tree problem solution #130
Conversation
- Solution based on https://www.geeksforgeeks.org/bottom-view-binary-tree/ - Modified `.gitignore` to ignore Visual Studio's files
Fixes #120
Hi @karimelazzouni you can use new Map() instead of installing hashmap dependencies. In es6 new Map() is there to create Map object.
Hi @TheSTL , I implemented the changes. If you have no more comments let's merge this.
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you undo these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should return an array instead of Iterator @karimelazzouni
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes required:
- Remove Unnecessary Changes .
- Function should return an array from most left child to most right child.
- Removed unnecessary dependencies in `packages.json` - Changed returned value to array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @karimelazzouni for PR. 💯
BinaryTreeas a parameter and returns the bottom view as an integer array.gitignoreto ignore Visual Studio's files