Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Implement Binary Tree to Binary Search Tree Conversion - Solution #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheSTL merged 2 commits into knaxus:master from k88manish:master
Oct 26, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/_Problems_/binary-tree-to-binary-search-tree/Node.js
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module.exports = class Node {
constructor(value) {
this.value = value;
this.leftChild = null; // will be a node
this.rightChild = null; // will be a node
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can re-use the Node class already present in the codebase

Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
const { binaryTreeToBST, storeInorder } = require('.');
const Node = require('./Node');

describe('Binary tree to binary search tree', () => {
let tree;

describe('Create Binary Tree', () => {
tree = new Node(10);
tree.leftChild = new Node(30);
tree.leftChild.leftChild = new Node(20);
tree.rightChild = new Node(15);
tree.rightChild.rightChild = new Node(5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary Tree implementation is already present.

ashokdey reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k88manish, you can use this Binary Tree using level order to create the tree here.

});

it('Should converted binary tree to binary search tree', () => {
binaryTreeToBST(tree);
expect(storeInorder(tree)).toEqual([5, 10, 15, 20, 30]);
});
});
65 changes: 65 additions & 0 deletions src/_Problems_/binary-tree-to-binary-search-tree/index.js
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
/**
* Given a Binary Tree, convert it to a Binary Search Tree.
* The conversion must be done in such a way that keeps the original structure of Binary Tree.
* Example 1
Input:
10
/ \
2 7
/ \
8 4
Output:
8
/ \
4 10
/ \
2 7
*/

// Helper function to store inorder traversal of a binary tree
function storeInorder(root) {
/** left - root - right */
if (root === null) return [];

// First store the left subtree
let arr = [];
const left = storeInorder(root.leftChild);
arr = [...left, ...arr];

// Append root's data
arr = [...arr, root.value];

// Store right subtree
const right = storeInorder(root.rightChild);
arr = [...arr, ...right];
return arr;
}
Comment on lines +21 to +37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better way to do this is to create a file inside Problems/tree-traversal directory nd have the following:

  • inorderTraversal(root) : returns array of elements
  • preorderTraversal(root) : returns array of elements
  • so on...

And re-use the function here.

Alternatively, I am going forward to create these as helpers inside DataStructures/Trees/traversal so that they can be re-used

TheSTL reacted with hooray emoji

// Helper function to copy elements from sorted array to make BST while keeping same structure
function arrayToBST(arr, root) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention the runtime complexity of this function?

const node = root;
// Base case
if (!node) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to return null meaning the tree is empty


// First update the left subtree
arrayToBST(arr, node.leftChild);

// update the root's data and remove it from sorted array
node.value = arr.shift();

// Finally update the right subtree
arrayToBST(arr, node.rightChild);
}

function binaryTreeToBST(root) {
// Tree is empty
if (!root) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return null

const arr = storeInorder(root);
arr.sort((a, b) => a - b);
arrayToBST(arr, root);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSTL, shouldn't it return a new BST?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashokdey Yes, it should return the root node of new created BST.

ashokdey reacted with thumbs up emoji
}

module.exports = {
binaryTreeToBST,
storeInorder,
};

AltStyle によって変換されたページ (->オリジナル) /