-
Notifications
You must be signed in to change notification settings - Fork 269
Adding Check if a binary tree is subtree of another binary tree #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheSTL
merged 2 commits into
knaxus:master
from
abuasifkhan:abuasifkhan_adding_check-binary-tree-subtree-another-binary-tree
Oct 22, 2019
Merged
Adding Check if a binary tree is subtree of another binary tree #123
TheSTL
merged 2 commits into
knaxus:master
from
abuasifkhan:abuasifkhan_adding_check-binary-tree-subtree-another-binary-tree
Oct 22, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSTL
TheSTL
reviewed
Oct 21, 2019
src/_DataStructures_/Trees/BinaryTree/check-binary-tree-subtree-another-binary-tree/index.js
Outdated
Show resolved
Hide resolved
TheSTL
TheSTL
requested changes
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abuasifkhan
Changes required:
- Fix variable
- Add time complexity. You can check this problem to get an idea get_subsequence
@TheSTL, I've implemented the suggestions you added. Please approve the changes in everything looks good.
TheSTL
TheSTL
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @abuasifkhan 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding and exporting a function that can take two arguments as source tree and the tree that has to be matched and checks if the second tree is the subtree of the source tree.
Logic from: https://www.geeksforgeeks.org/check-if-a-binary-tree-is-subtree-of-another-binary-tree/