-
Notifications
You must be signed in to change notification settings - Fork 269
Armstrong Number solved #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added armstrongNum.js
hey, @TheSTL can you help me with what is the failing check about?
By reading this post from stack over flow I think coverage is decreased because some code lines are not covered in test cases. And we can get it by total test cases* code not covered in one test case.
Code not covered in single test case is because of Control Structures
.
Example this code num = (!Number.isNaN(Number(num))) ? parseInt(Math.abs(Number(num)), 10).toString() : (() => { throw Error('error')
@ashokdey @Omkaragrawal
@Omkaragrawal I think Armstrong Number should not be tested for decimals. It should throw error for decimal number or any other input except Integer.
- Remove tests for decimals.
- Add test cases where it should except to throw error
Hey, there are some minor changes in the test that's it, give me some time since I have my University exams till 28th.
Ok.
Hey @ashokdey I regret that I totally forgot about this. I will get to this soon and rewrite the tests.
Fixed #113 added armstrong number.