Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Armstrong Number solved #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Omkaragrawal wants to merge 2 commits into knaxus:master from Omkaragrawal:Armstrong
Closed

Conversation

Copy link

@Omkaragrawal Omkaragrawal commented Oct 21, 2019

Fixed #113 added armstrong number.

Copy link
Author

hey, @TheSTL can you help me with what is the failing check about?

Copy link
Member

TheSTL commented Oct 23, 2019

By reading this post from stack over flow I think coverage is decreased because some code lines are not covered in test cases. And we can get it by total test cases* code not covered in one test case.
Code not covered in single test case is because of Control Structures.
Example this code num = (!Number.isNaN(Number(num))) ? parseInt(Math.abs(Number(num)), 10).toString() : (() => { throw Error('error')
@ashokdey @Omkaragrawal

Copy link
Author

Hey,
@TheSTL @ashokdey so is it ok? If not what do I need to do for it, add a case that evaluates the error?

Copy link
Member

TheSTL commented Oct 24, 2019

@Omkaragrawal I think Armstrong Number should not be tested for decimals. It should throw error for decimal number or any other input except Integer.

  • Remove tests for decimals.
  • Add test cases where it should except to throw error

Copy link
Author

Hey, there are some minor changes in the test that's it, give me some time since I have my University exams till 28th.

Copy link
Member

ashokdey commented Nov 1, 2019

Ok.

Omkaragrawal reacted with laugh emoji

Copy link
Author

Hey @ashokdey I regret that I totally forgot about this. I will get to this soon and rewrite the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSTL TheSTL Awaiting requested review from TheSTL

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Armstrong No.

AltStyle によって変換されたページ (->オリジナル) /