-
Notifications
You must be signed in to change notification settings - Fork 23
add apply #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add apply #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use this line of code?
otherThis.__proto__.uniqueID = this;
@ashishdutta007
ashishdutta007
Oct 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSTL Why do we need to use this instead of otherThis[uniqueID] = this; . Can you elaborate ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By doing this we are making a pair of key-value in otherThis where key is some random id and value is function on which apply is called. When we call the function of otherThis (otherThis.uniqueID(...arr)) then in function this value will be otherThis.
@ashishdutta007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSTL The same is being done by @tamirisapbonicenha in line no 30 & 35
result = otherThis[uniqueID]();.
The only benefit what I can see from using otherThis.__proto__.uniqueID = this; in place of
otherThis[uniqueID] = this; is that there is no chance of collision of the unique id in the prototype object.
Moreover is __proto__ is a browser implementation , instead of a built in js implementation.
Is there something I'm missing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually problem is the uniqueId property is printed .You can check snapshot #23 (review)
@ashishdutta007
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashishdutta007 for telling me Moreover is __proto__ is a browser implementation , instead of a built in js implementation.. I'm testing things on browser .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And for 32-35 can you use this line of code?
result = otherThis.uniqueID(...arr);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete otherThis.__proto__.uniqueID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tamirisapbonicenha , your implementation is great 👍
Can you use let instead of var?
But there are few cases where your code doesn't match the apply method .
uniqueId property is printed
image
To handle this bug i have commented where changes are required .
Should throw error of arr argument is not array
image
Can you handle this bug?
Hi @TheSTL sorry for the delay, trouble made me disappear these days. I read the conversations and I will work on them on Sunday, all right?
Uh oh!
There was an error while loading. Please reload this page.
Add my own Function.prototype.apply().
#21