Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow recursion using ,recurse#20

Open
SilverCory wants to merge 2 commits into
kisielk:master from
SilverCory:master
Open

Allow recursion using ,recurse #20
SilverCory wants to merge 2 commits into
kisielk:master from
SilverCory:master

Conversation

@SilverCory

@SilverCory SilverCory commented Mar 23, 2021

Copy link
Copy Markdown

This allows sql:"..." to recurse into the struct tagged.

kisielk commented Mar 24, 2021

Copy link
Copy Markdown
Owner

Hm, wouldn't just ".." be more familiar looking?

Copy link
Copy Markdown
Author

I was going along the lines of func(t ...T), if I saw .. I would thing up in the hierarchy not down

Copy link
Copy Markdown

But this isn't about varargs. If it needs to be any amount of dots, I believe a single . makes most sense since you are accessing a member of the struct, going down one level in the hierarchy, which is exactly what it looks like elsewhere in the language.

A different idea: add another tag-field. Kinda how for json we may write json:",omitempty" we could write sql:",recurse".

@SilverCory SilverCory changed the title (削除) Allow recursion using ... (削除ここまで) (追記) Allow recursion using ,recurse (追記ここまで) Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /