-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Conversation
kisielk
commented
Mar 24, 2021
Owner
Hm, wouldn't just ".." be more familiar looking?
SilverCory
commented
Mar 24, 2021
Author
I was going along the lines of func(t ...T), if I saw .. I would thing up in the hierarchy not down
MMulthaupt
commented
Jul 30, 2021
But this isn't about varargs. If it needs to be any amount of dots, I believe a single . makes most sense since you are accessing a member of the struct, going down one level in the hierarchy, which is exactly what it looks like elsewhere in the language.
A different idea: add another tag-field. Kinda how for json we may write json:",omitempty" we could write sql:",recurse".
@SilverCory
SilverCory
force-pushed
the
master
branch
from
February 6, 2024 23:18
f39c372 to
c9077e5
Compare
@SilverCory
SilverCory
changed the title
(削除) Allow recursion using
(追記) Allow recursion using Feb 6, 2024
... (削除ここまで),recurse (追記ここまで)
@SilverCory
SilverCory
force-pushed
the
master
branch
from
February 6, 2024 23:33
86c60f3 to
c2e1b84
Compare
@SilverCory
SilverCory
force-pushed
the
master
branch
from
February 6, 2024 23:41
c2e1b84 to
bd9ac04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
sql:"..."to recurse into the struct tagged.