Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Dockerfile and Refactor Weather Alert Application: User Input for Dynamic Weather Alerts #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amitabh-DevOps wants to merge 8 commits into king04aman:main
base: main
Choose a base branch
Loading
from Amitabh-DevOps:feature

Conversation

Copy link

@Amitabh-DevOps Amitabh-DevOps commented Oct 25, 2024
edited
Loading

Developer Checklist

  • Adhered to the guidelines outlined in the README & Contributing file.
  • Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
  • Please ensure to include a README file for enhanced project clarity.
  • Starred ⭐ the repository (optional).

Summary

This pull request introduces a Dockerfile for the weather alert application, streamlining the deployment process and ensuring consistent environments across different systems. Additionally, it refactors the application to include a user input form for city names, enabling dynamic weather alert checks based on user-defined locations. The application retrieves weather data in real-time, enhancing user engagement and usability.

However, the application is currently hosted on localhost, limiting its accessibility. Future work should focus on deploying the application to a cloud platform to allow users from various locations to access the service. Additionally, implementing AJAX could allow for real-time updates without requiring a page refresh, making the application more dynamic.

Suggestion: Consider developing this application using Django for better structure and scalability. I would be happy to assist in making improvements and implementing best practices in that framework.

Screenshot

Screenshot 2024年10月25日 155527

Screenshot 2024年10月25日 155151

Screenshot 2024年10月25日 155207

Copy link
Contributor

👋 @Amitabh-DevOps 👋

We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon.

Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Amitabh-DevOps,

Thank you for your valuable contribution. We already have the project available in this repository. If you would like to contribute to the same project, please create a directory within the existing Weather Alert directory. I recommend using the following structure: Weather Alert/your-usrName/project-files (excluding the project name, as that directory is already defined).

Thank you!

Copy link
Author

Amitabh-DevOps commented Oct 26, 2024 via email

Yes i have done with changes which you have said , now review it
...
On Fri, Oct 25, 2024 at 10:58 PM Aman Kumar ***@***.***> wrote: ***@***.**** requested changes on this pull request. Hi @Amitabh-DevOps <https://github.com/Amitabh-DevOps>, Thank you for your valuable contribution. We already have the project available in this repository. If you would like to contribute to the same project, please create a directory within the existing Weather Alert directory. I recommend using the following structure: Weather Alert/your-usrName/project-files (excluding the project name, as that directory is already defined). Thank you! — Reply to this email directly, view it on GitHub <#85 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BKAIEHVFCZZZHQ4EZP7VBPLZ5J5SDAVCNFSM6AAAAABQS765RCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJVHE2TGMZXGE> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

Copy link
Author

If there is any changes you want to suggest it please go ahead
and review it if it is ok then proceed it

i have did not modified the existing code , i just created a dir with my username as you have told
some how i have to copy the existing code of Weather Alert to get back the existing with seprately because i have changed the origanl README.md and all so make sure to check that also

Copy link
Author

I think it is so long time done , please check my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@king04aman king04aman Awaiting requested review from king04aman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /