Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

File organizer #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OkenHaha wants to merge 2 commits into king04aman:main
base: main
Choose a base branch
Loading
from OkenHaha:file_organizer
Open

File organizer #77

OkenHaha wants to merge 2 commits into king04aman:main from OkenHaha:file_organizer

Conversation

Copy link

@OkenHaha OkenHaha commented Oct 22, 2024
edited
Loading

Developer Checklist

  • Adhered to the guidelines outlined in the README & Contributing file.
  • Maintained the correct directory structure (e.g., ProjectName/...yourfiles).
  • Please ensure to include a README file for enhanced project clarity.
  • Starred ⭐ the repository (optional).

Summary

Please provide a brief summary here.

Create a Python Script to organize files corresponding to file types for a given directory. Pull Request for Issue #29

Screenshot

Attach any relevant screenshots or GIFs here.

Live Project Link

Include a link to the live project here.

Copy link
Contributor

👋 @OkenHaha 👋

We're delighted to have your pull request! Please take a moment to check our contributing guidelines and ensure you've filled out the PR template for a smooth process. We will review it soon.

Copy link
Owner

@king04aman king04aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OkenHaha,

Thanks for your submission of the File Organizer project! I really appreciate your effort. Here are a few suggestions that could help improve it:

  • Consider adding validation for the input path to ensure it exists and is accessible.
  • Your README.md provides a good overview, but adding more detailed instructions, example usage, and notes on customizing file types would be helpful.
  • It would be beneficial to add try-except blocks around file operations to handle potential errors like permission issues or invalid paths.
  • The 'others' category is defined but left empty, clarifying that files not matching known types will go there would be useful.

Overall, this is a solid implementation! By enhancing the documentation and adding a bit of error handling, it can be even better. Looking forward to your updates!

Copy link
Author

@king04aman Understandable. I will start implementing it and make a pull request again soon.

king04aman reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@king04aman king04aman king04aman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /