-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Conversation
This is a simple two port router board, with the same WiFi chips as BPI-r3. The bootloader shall be the same as the BPI-r3, the bootloader now probes which of the two is booting by checking for the PHYS that only exist on BPI-r3-mini.
The important part is that it needs a special flow to go from vendor firmware to Infix.
$? needs to be $$? inside a make rule to expand the bash variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the Banana Pi BPI-R3 Mini board, which shares the same SoC and bootloader as the BPI-R3 but has key hardware differences including an EN8811H Ethernet PHY instead of a switch.
Changes:
- Added runtime board variant detection in U-Boot to differentiate between BPI-R3 and BPI-R3 Mini
- Integrated Airoha EN8811H PHY driver with firmware loading support from MMC partition
- Added device tree and configuration files for BPI-R3 Mini
Reviewed changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| utils/mkimage.sh | Adds EN8811H firmware image preparation functions |
| test/test.mk | Fixes shell variable escaping in test command |
| patches/uboot/2025.01/0007-bpi-r3-r4-Add-probe-for-specific-model.patch | Adds U-Boot board detection code for BPI-R3/R3-mini/R4 variants |
| patches/uboot/2025.01/0006-Add-bpi-r3-mini-device-tree.patch | Adds BPI-R3 Mini device tree to U-Boot |
| patches/uboot/2025.01/0005-net-phy-Add-the-Airoha-EN8811H-PHY-driver.patch | Adds Airoha EN8811H PHY driver to U-Boot |
| patches/uboot/2025.01/0004-arm-dts-at91-sama7g5ek-supports-high-speed-on-mmc0-e.patch | Enables eMMC high-speed capabilities for sama7g5ek |
| patches/uboot/2025.01/0003-arm-dts-at91-sama7g5ek-increase-clock-for-sdmmc-from.patch | Increases SDMMC clock frequency for sama7g5ek |
| patches/uboot/2025.01/0002-add-rpidisplay-check.patch | Adds RPi display detection command |
| patches/uboot/2025.01/0001-hush-Remove-Ctrl-C-detection-in-loops.patch | Removes Ctrl-C detection in shell loops |
| doc/ChangeLog.md | Documents BPI-R3 Mini support addition |
| configs/bpi_r3_emmc_boot_defconfig | Enables Airoha EN8811H firmware in buildroot config |
| buildroot | Updates buildroot submodule reference |
| board/aarch64/bananapi-bpi-r3/uboot/mt7986-env.dtsi | Adds EN8811H firmware environment variables |
| board/aarch64/bananapi-bpi-r3/uboot/extras.config | Enables EN8811H PHY driver and multi-DTB fit support |
| board/aarch64/bananapi-bpi-r3/rootfs/usr/share/product/bananapi,bpi-r3mini/etc/udev/rules.d/90-bpi-r3-mini-rename-ethernet.rules | Adds udev rules for BPI-R3 Mini ethernet naming |
| board/aarch64/bananapi-bpi-r3/rootfs/usr/share/product/bananapi,bpi-r3mini/etc/product/init.d/S01-trigger-udev.sh | Adds init script for triggering udev events |
| board/aarch64/bananapi-bpi-r3/rootfs/usr/share/product/bananapi,bpi-r3mini/etc/factory-config.cfg | Adds factory configuration for BPI-R3 Mini |
| board/aarch64/bananapi-bpi-r3/genimage.cfg.in | Adds EN8811H firmware partition to image layout |
| board/aarch64/bananapi-bpi-r3/dts/mediatek/mt7986a-bananapi-bpi-r3.dtsi | Removes upstream include to avoid duplication |
| board/aarch64/bananapi-bpi-r3/dts/mediatek/mt7986a-bananapi-bpi-r3-sd.dts | Restores upstream include for SD variant |
| board/aarch64/bananapi-bpi-r3/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtsi | Adds device tree include for BPI-R3 Mini |
| board/aarch64/bananapi-bpi-r3/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dts | Adds complete device tree for BPI-R3 Mini with PHY overrides |
| board/aarch64/bananapi-bpi-r3/dts/mediatek/mt7986a-bananapi-bpi-r3-emmc.dts | Restores upstream include for eMMC variant |
| board/aarch64/bananapi-bpi-r3/dts/Makefile | Adds BPI-R3 Mini device tree to build |
| board/aarch64/bananapi-bpi-r3/bananapi-bpi-r3.mk | Enables EN8811H PHY kernel module |
| board/aarch64/bananapi-bpi-r3/README.md | Updates documentation for BPI-R3 Mini installation |
| board/aarch64/bananapi-bpi-r3/Config.in | Adds Airoha EN8811H firmware dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: