Auto-scale Y-axis for indicators when zooming #356 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

zlpatel wants to merge 1 commit into kernc:master

from zlpatel:kernc#356

Open

Auto-scale Y-axis for indicators when zooming #356 #389

zlpatel wants to merge 1 commit into kernc:master from zlpatel:kernc#356

Conversation

zlpatel

Copy link

Contributor

@zlpatel zlpatel commented Jun 17, 2021 •

edited by kernc

Loading

Fixes #356

@zlpatel


 Auto-scale Y-axis for indicators when zooming kernc#356

c6eb56f

Benouare

Benouare approved these changes

Jun 18, 2021

View reviewed changes

@kernc kernc mentioned this pull request

Jun 21, 2021

Auto-scale Y-axis for indicators when zooming #356 #357

Closed

zlpatel

zlpatel commented

Jun 21, 2021

View reviewed changes

backtesting/_plotting.py

custom_js_args = dict(ohlc_range=fig_ohlc.y_range,

source=source)

if plot_pl:

custom_js_args.update(pl_range=fig_pl.y_range)

Copy link

Contributor Author

@zlpatel zlpatel Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was not required. I think I might have added that while I was trying to see if I can add auto scale feature for P/L chart. Since it's already been added in the commit, I still see a value in keeping it for future use, But if you think that it's not worth adding it right now and will cause confusion then I can remove it. Let me know.