-
-
Notifications
You must be signed in to change notification settings - Fork 289
Conversation
@Achanandhi-M
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Srinu346, the changes look really good, and I’ve tested them locally as well. However, from our side, we don’t want to include any bunny image or custom design for the 404 page.
If a user types a 404 URL or visits a non-existent page, it should simply redirect to /docs (the docs homepage). Please update it accordingly.
Image742cc31 to
4b7bebb
Compare
Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
Srinu346
commented
Jan 6, 2026
This is the view after changes @Achanandhi-M sir,
- Reduced the timer to 4s
- Removed the bunny image
Achanandhi-M
commented
Jan 7, 2026
Hey @Srinu346, please check the previous comment. As mentioned, we don’t want to show any bunny or anything on redirection—if the page is a 404, it should redirect to the home page immediately. Please have a look at the previous comment for details.
Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
Srinu346
commented
Jan 9, 2026
-
Current View
https://github.com/user-attachments/assets/6cdc9abf-adde-4eba-aef5-a6bbc6ce5bf7 -
Build Results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Srinu346, we don’t want to show a 404 or any other message while redirecting. It should simply redirect to the home page immediately.
Signed-off-by: Akella Srinivas <alsrinivas.346@gmail.com>
Srinu346
commented
Jan 9, 2026
@Achanandhi-M sir, now i have removed that message also, it simply redirects it to home page.
Srinu346
commented
Jan 12, 2026
@Achanandhi-M sir, are there any more changes required here ?
Srinu346
commented
Jan 27, 2026
@Achanandhi-M sir can you please review this pr.
@Achanandhi-M
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Srinu346, we’ve updated the landing page. Could you please review the new version? Also, please add a short video demonstrating your changes. Thanks!
Srinu346
commented
Jan 27, 2026
@Achanandhi-M Sir the issue is not resolved.
f0c2925 to
2ce1bcb
Compare
Srinu346
commented
Jan 27, 2026
Sir the white strip is caused by an already existing issue.
Screen.Recording.2026年01月27日.225242.mp4
@amaan-bhati
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for iterating on this and removing the earlier custom design elements per reviewer feedback. The useBaseUrl approach is the correct, Docusaurus-idiomatic way to handle this redirect.
Consider working through a few things:
Issues to be Considered
1. Duplicate PR
There is another open PR that addresses the same issue and modifies the same file using a hardcoded path. Only one of these can be merged. The useBaseUrl approach here is technically superior as it remains correct even if the site's base URL changes in the future. The maintainer should close the other PR in favor of this one.
2. Missing demo video
The reviewer requested a short demo video showing that navigating to a non-existent URL redirects cleanly to the docs homepage. Please provide this before requesting re-review.
3. Redirect method
Please confirm the final implementation uses window.location.replace(homeUrl) rather than history.push - replace is preferred for 404 redirects as it does not add the broken URL to the user's browser history.
Srinu346
commented
Apr 20, 2026
OK sir, I will add a demo video.
Srinu346
commented
Apr 30, 2026
Here is the demo video sir, and yes window.location.replace(homeUrl) approach is being used.
Screen.Recording.2026年04月30日.143322.mp4
Please take a look @amaan-bhati sir.
@amaan-bhati
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Srinu346 thanks for sharing the video, can you add one more video with more context? in this video the implementation seems to be breaking, it is taking 3-4 seconds to redirect, and while it is getting redirected, we are seeing a blank screen both while loading and also when it is redirected, the page seems to be empty. my personal suggestion is to see the working of the 404 pages from blog website, it might help you improve your implementation and ideation as well.
What has changed?
This PR adds a custom, user-friendly 404 error page to the Keploy documentation site. The new 404 page replaces the previous redirect-only behavior with a comprehensive, visually appealing error page that helps users navigate back to relevant content.
Key Features:
Technical Changes:
src/theme/NotFound/Content/index.jsto include:useBaseUrlfor proper asset pathsThis PR Resolves #3441
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Build and Serve Testing:
npm run build- Build completed successfully with no errorsnpm run serve- Development server started without issues/docs/nonexistent-page/docs/invalid/route/random-pathFunctionality Testing:
/img/404-error.pngScreenshots:
Desktop View (Light Mode)
Screenshot 2026年01月01日 202958 Screenshot 2026年01月01日 203004Desktop View (Dark Mode)
Screenshot 2026年01月01日 202904 Screenshot 2026年01月01日 202910Mobile View
imageChecklist:
Additional Notes:
404-error.png) should be placed instatic/img/directoryuseState(12)value