-
-
Notifications
You must be signed in to change notification settings - Fork 165
FE: Messages: impl message reproduce #1207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kapybro
kapybro
bot
added
status/triage
Issues pending maintainers triage
status/triage/manual
Manual triage in progress
status/triage/completed
Automatic triage completed
and removed
status/triage
Issues pending maintainers triage
labels
Jul 21, 2025
@github-actions
github-actions
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi benaskiburtas! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
@benaskiburtas
benaskiburtas
force-pushed
the
main
branch
from
July 21, 2025 22:31
f1bdefb
to
fc8824f
Compare
@benaskiburtas
benaskiburtas
force-pushed
the
main
branch
2 times, most recently
from
August 2, 2025 18:40
f1bdefb
to
d7f7748
Compare
@Haarolean
Haarolean
added
type/enhancement
En enhancement/improvement to an already existing feature
scope/frontend
Related to frontend changes
area/messages
and removed
status/triage/manual
Manual triage in progress
labels
Aug 3, 2025
@github-project-automation
github-project-automation
bot
moved this to Todo
in Release 1.4
Aug 3, 2025
@benaskiburtas
benaskiburtas
force-pushed
the
main
branch
from
August 11, 2025 19:14
d7f7748
to
cfad322
Compare
@Haarolean
Haarolean
changed the title
(削除) FE: Add dropdown action to re-produce existing message into topic (#247) (削除ここまで)
(追記) FE: Messages: impl message reproduce (追記ここまで)
Aug 15, 2025
@benaskiburtas
benaskiburtas
force-pushed
the
main
branch
from
August 16, 2025 14:46
cfad322
to
68ea7c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What changes did you make? (Give an overview)
Resolves #247
Added a new action to the message action dropdown as suggested on #247:
image
This is implemented via a hook
useProduceMessage
andTopicActionsContext
to interact with the side-bar while avoiding prop drilling.Action will prefill:
SendMessage.tsx had some aria labels misconfigured, adjusted some properties slightly to point to actual labels.
Is there anything you'd like reviewers to focus on?
ResourceType.TOPIC
&Action.MESSAGES_PRODUCE
permissions, same as the existing standalone action. The initial issue description suggested a new permission specifically for reproducing a message (e.g.Action.MESSAGES_REPRODUCE
?). Do let me know if that would be preferred; :)How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
659373-2292747750