-
Notifications
You must be signed in to change notification settings - Fork 6
Change code block style #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I do like the indenting. My initial reaction to the background change is that things look a bit 'stark' now. Though I admit am conditioned by the way that GitHub and Slack do things -- I'm used to some sort of box denoting a code block.
Ultimately I don't feel particularly strongly, but I'd probably come down on the side of having more than just a font and indent change signifying that something is a piece of code. I'm not sure what your underlying reason for the change is, so it's a bit hard to suggest good alternatives.
The existing grey blocks are certainly a bit ugly. Would it help to prettify them a bit? Both GitHub and Slack have nice rounded corners on the code blocks. Slack uses just a thin grey border and leaves the background colour untouched. Could something like that work?
Thanks for the feedback. You and @rpendleton think alike.
Uh oh!
There was an error while loading. Please reload this page.
@aharrison24 any opinions?