-
Notifications
You must be signed in to change notification settings - Fork 6
fix item numbering in chapter 8 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
aharrison24
wants to merge
1
commit into
justinmeiners:master
from
aharrison24:chapter8-item-numbering
Closed
fix item numbering in chapter 8 #27
aharrison24
wants to merge
1
commit into
justinmeiners:master
from
aharrison24:chapter8-item-numbering
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You're right that all these solutions sound terrible.
I think I found the hack I prefer:
4. `free`:
Ah OK, the span
tags don't actually add anything in this case do they. That'll teach me for cargo-culting code without taking the time to actually engage my brain.
One  
or 3x
looks like the least worst options!
I didn't know about  
. I'll give that a try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Currently the numbered list in chapter 8 has the incorrect number against the 4th entry, because the markdown processor interprets it as a new list and starts the numbering at 1 again.
There doesn't seem to be any trivial way of marking up the list so that it starts at 4.
discount
doesn't seem to accept the{:start="4"}
syntax that you can use with some other markdown processors.This PR resorts to using some inline HTML to solve the problem. I suspect that might be unpalatable, so please feel free to summarily reject it! :-)
A different way of achieving more or less the same effect would be to use inline HTML to generate the list entry manually, like this:
It works... but it's probably less robust to changes in the CSS.
🤷