-
Notifications
You must be signed in to change notification settings - Fork 9
Accept infinite function paramaters #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very good catch @appleplectic . Thanks for that.
I will be happy to accept your PR. But, there is one other place that needs to be changed. Please have a look at evaluatorAsync
jspython/src/evaluator/evaluatorAsync.ts
Line 166 in 8d98398
At the moment, evaluator and evaluatorAsync contain duplicated logic. This will be refactored in the nearest future. But, for now, we have to maintain the same logic in both files.
Thanks,
Pavlo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please apply the same changes to invokeFunctionAsync
jspython/src/evaluator/evaluatorAsync.ts
Line 166 in 8d98398
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
evaluatorAsync needs to be changed as well
jspython/src/evaluator/evaluatorAsync.ts
Line 166 in 8d98398
N-Pelletant
commented
Jun 15, 2022
@appleplectic is not spreading the correct parameter. He is spreading args when he should be spreading fps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the other function and spread fps
No description provided.