-
-
Notifications
You must be signed in to change notification settings - Fork 346
Fix normative vs informative references #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks good at a glance
... On Nov 16, 2017 19:52, "Henry Andrews" ***@***.***> wrote:
Addresses #471
<#471>. Note
that no changes were needed in the core spec, and the commented-out RFC
reference that was left in hyper-schema will be addressed by the next PR.
I left the HTTP RFCs (including PATCH) as informative because there is
guidance on how they are used but I don't think anything rises to the level
of a testable requirement, even an optional one. Implementations, for
instance, are not obligated to look for "accept-patch" in "targetHints",
and if they do, the general directive that the meta-data is treated
according to whatever protocol is in use is sufficient. Additional
information is present only to reduce confusion.
The one way in which this might not be correct is the requirement that API
implementors MUST NOT define POST semantics for a collection other than
collection item creation semantics. That hinges on the use of POST. But
it's not actually a requirement for Hyper-Schema implementations, it's a
requirement for hyper-schema users. I'm not sure how that's supposed to
work (or if that's improperly written to start with).
------------------------------
You can view, comment on, or merge this pull request online at:
#496
Commit Summary
- Validation spec normative reference audit
- Hyper-Schema spec normative reference audit
File Changes
- *M* jsonschema-hyperschema.xml
<https://github.com/json-schema-org/json-schema-spec/pull/496/files#diff-0>
(8)
- *M* jsonschema-validation.xml
<https://github.com/json-schema-org/json-schema-spec/pull/496/files#diff-1>
(30)
Patch Links:
- https://github.com/json-schema-org/json-schema-spec/pull/496.patch
- https://github.com/json-schema-org/json-schema-spec/pull/496.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#496>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAatDdwEUi8bO1li7X0QbOhIH0BNvEwWks5s3PTbgaJpZM4Qhdlr>
.
dlax
dlax
approved these changes
Nov 17, 2017
@gregsdennis
gregsdennis
added
clarification
Items that need to be clarified in the specification
and removed
Type: Maintenance
labels
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #471. Note that no changes were needed in the core spec, and the commented-out RFC reference that was left in hyper-schema will be addressed by the next PR.
I left the HTTP RFCs (including PATCH) as informative because there is guidance on how they are used but I don't think anything rises to the level of a testable requirement, even an optional one. Implementations, for instance, are not obligated to look for "accept-patch" in "targetHints", and if they do, the general directive that the meta-data is treated according to whatever protocol is in use is sufficient. Additional information is present only to reduce confusion.
The one way in which this might not be correct is the requirement that API implementors MUST NOT define POST semantics for a collection other than collection item creation semantics. That hinges on the use of POST. But it's not actually a requirement for Hyper-Schema implementations, it's a requirement for hyper-schema users. I'm not sure how that's supposed to work (or if that's improperly written to start with).