Rename some href* keywords to template* #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

handrews merged 2 commits into json-schema-org:master from handrews:template-not-href

Oct 8, 2017

Merged

Rename some href* keywords to template* #420

handrews merged 2 commits into json-schema-org:master from handrews:template-not-href

Oct 8, 2017

Conversation

handrews

Copy link

Contributor

@handrews handrews commented Sep 23, 2017 •

edited

Loading

Addresses part of #416. Since "href", "anchor", and "base" all share the use of "hrefPointers" and "hrefRequired", let's call them something more generic. Note that since "hrefSchema" is NOT used with "anchor", it retains its existing name.

I am not particularly attached to the template* prefix. I considered uri*, but then would we want to change it to iri*? So I went with template*. But other suggestions are welcome.

handrews added 2 commits

September 23, 2017 11:06

@handrews


 Rename some href* keywords to template*

b01c13a

Addresses part of json-schema-org#416. Since "href", "anchor", and "base"
all share the use of "hrefPointers" and "hrefRequired",
let's call them something more generic. Note that since
"hrefSchema" is NOT used with "anchor", it retains its
existing name.

@handrews


 Update links.json for href* to template* rename.

884b964

@handrews handrews added hypermedia Priority: Medium labels

Sep 23, 2017

@handrews handrews added this to the draft-07 (wright-*-02) milestone

Sep 23, 2017

@handrews handrews requested review from philsturgeon, awwright and dlax

September 23, 2017 18:15

@handrews handrews changed the title ~~(削除) Rename some href* keywords to template (削除ここまで)~~ (追記) Rename some href* keywords to template* (追記ここまで)

Sep 23, 2017

@dlax

Copy link

Member

dlax commented Sep 25, 2017

Renaming the keywords doesn't seem sufficient because most of surrounding texts still refers to href only (see https://github.com/handrews/json-schema-spec/blob/b01c13a6d1744f5bbe0ad4339b60bdc38ffaf414/jsonschema-hyperschema.xml#L358 for instance). Maybe it's just a first step and you plan to rework this as part of the rewrite?

The template prefix looks fine, I don't have a better idea at the moment.