Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add non-http "method": "post" LDO example #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
handrews merged 1 commit into json-schema-org:master from handrews:enctype
Mar 27, 2017

Conversation

Copy link
Contributor

@handrews handrews commented Mar 23, 2017

This PR need not necessarily go into Draft 06

I'm posting this mostly to illustrate some of the arguments in #280, particularly around avoiding coupling of JSON Hyper-Schema and any particular URI scheme or protocol.

If we can't figure out a reasonable mapping for mailto: then we might be missing something. Although that something will probably need to wait until Draft 07 for a fix.

I am aware that it's more common to use an HTTP request to ask the server to send mail, but I think this still makes a good example. If the client for this resource runs in a known environment, it could be reasonable to expect the client to send mail if it wants to.


Add an example showing how a non-HTTP URI scheme can be used,
showing a form for constructing an email with two different
representations, as well as requiring a subject.

"media": { "type": "text/html" }
}
],
"minItmes": 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: minItems

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh. Maybe I should remember to validate my examples against the meta-schema :-P

Add an example showing how a non-HTTP URI scheme can be used,
showing a form for constructing an email with two different
representations, as well as requiring a subject.
Copy link
Member

I think this makes sense. This is a lot like how you would do it with an HTML Form.

Copy link
Contributor Author

@awwright if you agree with @jdesrosiers that this is reasonable, should we go ahead and add it to Draft 06? It shouldn't change anything, only clarify.

@handrews handrews added this to the draft-next (draft-6) milestone Mar 26, 2017
Copy link
Member

It's maybe a bit more verbose than ought to be necessary, but still, a good illustration of this behavior is probably warranted.

Copy link
Contributor Author

@awwright I tend to be verbose, unfortunately. Anything in particular you'd trim?

Copy link
Contributor Author

@awwright did that comment count as an approval?

Copy link
Member

I think I just needed to sit on it another day. Looks good.

handrews reacted with thumbs up emoji

Copy link
Contributor Author

@awwright thanks! Totally reasonable, just wasn't quite clear :-)

@handrews handrews merged commit 436b1b4 into json-schema-org:master Mar 27, 2017
@handrews handrews deleted the enctype branch August 27, 2017 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awwright awwright awwright approved these changes

+1 more reviewer

@dlax dlax dlax left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
draft-6
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /