Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

re-unite meta-schema #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregsdennis merged 5 commits into main from gregsdennis/meta-schema
Jul 19, 2025
Merged

re-unite meta-schema #1610

gregsdennis merged 5 commits into main from gregsdennis/meta-schema
Jul 19, 2025

Conversation

Copy link
Member

@gregsdennis gregsdennis commented Jun 22, 2025
edited
Loading

What kind of change does this PR introduce?

Refactor

Issue & Discussion References

Summary

Re-unites the meta-schema into a single file since vocabularies are a proposal now. We will likely split it back up again when we figure out vocabs, but for now it doesn't make sense to have them separated.

Also:

  • removes any deprecated keywords
  • reserves the names of existing proposals
  • reserves x-* keywords
  • reserves $* keywords

Does this PR introduce a breaking change?

@gregsdennis gregsdennis marked this pull request as ready for review June 22, 2025 04:49
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this work.
Left one comment, but not essential.

Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member Author

@jdesrosiers I've updated the $-keyword restriction using your suggestion. It's a bit direct, but simple is probably better anyway.

@gregsdennis gregsdennis merged commit e929dbc into main Jul 19, 2025
6 checks passed
@gregsdennis gregsdennis deleted the gregsdennis/meta-schema branch July 19, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdesrosiers jdesrosiers jdesrosiers approved these changes

@Relequestual Relequestual Relequestual approved these changes

@jviotti jviotti jviotti approved these changes

+2 more reviewers

@notEthan notEthan notEthan left review comments

@gibson042 gibson042 gibson042 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Projects
Development

Successfully merging this pull request may close these issues.

Reunite the meta-schemas Unsupported deprecated keywords are listed in the metaschema

AltStyle によって変換されたページ (->オリジナル) /