-
-
Notifications
You must be signed in to change notification settings - Fork 351
Additional cleanup for dynamic references #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jdesrosiers
merged 1 commit into
json-schema-org:main
from
jdesrosiers:spec-cleanup-dynamic
Mar 11, 2025
Merged
Additional cleanup for dynamic references #1589
jdesrosiers
merged 1 commit into
json-schema-org:main
from
jdesrosiers:spec-cleanup-dynamic
Mar 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
gregsdennis
requested changes
Feb 25, 2025
@jdesrosiers
jdesrosiers
force-pushed
the
spec-cleanup-dynamic
branch
from
February 27, 2025 21:07
3ce655d
to
d152894
Compare
@jdesrosiers
jdesrosiers
force-pushed
the
spec-cleanup-dynamic
branch
from
March 3, 2025 18:42
d152894
to
b83c618
Compare
gregsdennis
gregsdennis
approved these changes
Mar 3, 2025
@jdesrosiers
jdesrosiers
force-pushed
the
spec-cleanup-dynamic
branch
from
March 11, 2025 03:50
53f65c0
to
ccff224
Compare
Co-authored-by: Greg Dennis <gregsdennis@yahoo.com>
@jdesrosiers
jdesrosiers
force-pushed
the
spec-cleanup-dynamic
branch
from
March 11, 2025 03:54
ccff224
to
2bff2fd
Compare
@jdesrosiers
jdesrosiers
merged commit Mar 11, 2025
086a872
into
json-schema-org:main
3 of 4 checks passed
@github-project-automation
github-project-automation
bot
moved this from In Progress
to Done
in Stable Release Development
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What kind of change does this PR introduce?
Clarification
Issue & Discussion References
Summary
This is mostly cleanup building on #1555, although I rewrote a couple of parts I though needed it.
The main objective is to achieve consistent and correct usage of terms around fragment identifiers. Here are the definitions I'm using.
#
character in an IRI.$anchor
creates a plain name fragment identifier.#
and is followed by a fragment identifier.(削除) fragment (削除ここまで)-- This term by itself is ambiguous and imprecise. I replaced all usages with a more precise term from the above terms.Here's a list of the other notable changes.
$dynamicAnchor
does not create a fragment identifier. It's a special kind of identifier unique to the dynamic reference mechanism. Specifically, you can't use the identifier created by$dynamicAnchor
in an IRI.$dynamicRef
Everything else is minor grammar fixes or whitespace cleanup.
Does this PR introduce a breaking change?
No. (Actually, the issue this closes is a breaking change, but this PR doesn't break anything. This is just cleanup related to and around that change.)