-
-
Notifications
You must be signed in to change notification settings - Fork 348
use more accurate regex vocabulary #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gregsdennis
merged 2 commits into
json-schema-org:main
from
gibson042:2024-11-regex-vocabulary
Feb 3, 2025
Merged
use more accurate regex vocabulary #1563
gregsdennis
merged 2 commits into
json-schema-org:main
from
gibson042:2024-11-regex-vocabulary
Feb 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
jdesrosiers
approved these changes
Nov 15, 2024
gregsdennis
gregsdennis
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
@gregsdennis
gregsdennis
merged commit Feb 3, 2025
a091943
into
json-schema-org:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Editorial
Issue & Discussion References
Summary
Referring to the difference between e.g.
.+and.+?as "laziness" isn't wrong, but it is less accurate than "greediness".Does this PR introduce a breaking change?
No.