add a root object to the output #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

gregsdennis wants to merge 2 commits into main

from gregsdennis/output-root

Open

add a root object to the output #1542

gregsdennis wants to merge 2 commits into main from gregsdennis/output-root

Conversation

gregsdennis

Copy link

Member

@gregsdennis gregsdennis commented Oct 12, 2024

What kind of change does this PR introduce?

feature

Issue & Discussion References

Should probably merge #1457 first, but it's not a hard dependency. If anything, I can move the file in this PR and just close that one.

Summary

This PR addresses some conversations that @jdesrosiers and I have had intermittently over the past few years. His point was that the output needed a place to add more metadata about an evaluation. So this is a first go at that.

It adds a root object that is defined separately from the output unit. Previously, the root object was just another output unit, but having a distinct root object does make sense.

I've added dialect and schema identifiers to the root object and tweaked the wording throughout.