-
-
Notifications
You must be signed in to change notification settings - Fork 345
Update output schema to describe new structure #1285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be iri now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see you're already on it, re the other PR about uri->iri changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to push this forward as I can't wait on your PR any longer. It needs to be rebased anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the 'basic' format contain 'nested'? My understanding was that basic is still a flat structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basic is an object with only valid and nested at the root. The rest is normal output units in the nested array.
{
"valid": true,
"nested": [ <flat list> ]
}This provides the overall validation result at the root and a flat list. It's the same as 2020-12, except that the location properties aren't required at the root (because they're always just / and redundant).
f365c65 to
0431059
Compare
Shouldn't this have gone into draft-next, not main?
@karenetheridge draft-next was merged some time ago.
Uh oh!
There was an error while loading. Please reload this page.
Updates the output schema file to match the new structure as described by the specification. Follow-up to #1249.
I've tested this against the example output in the spec.
Resolves #949