-
Notifications
You must be signed in to change notification settings - Fork 526
Adding encoding as parameter to methods deserialize and serialize #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...JsonStream.serialize
TheNeuralBit
commented
Feb 10, 2020
@taowen is there any chance this could get merged? it's fixing a pretty big issue
BTW, we are mostly starting to migrate to another JSON parser in which the development is more active.
pradeepcheers
commented
Aug 6, 2021
@leocampos what's the name of the new JSON parser that you mentioned the development is active
@pradeepcheers We are currently using Jackson.
https://github.com/FasterXML/jackson.
The approach we took, though, was to wrap it around a class of ours, so we can later choose the library and change it in a single place.
For UTF-16 this PR crashes with:
com.jsoniter.spi.JsonException: read: premature end, head: 1, peek: �, buf: �� { " n a m e " : " T h o m a s M � l l e r " } at com.jsoniter/com.jsoniter.JsonIterator.reportError(JsonIterator.java:143) at com.jsoniter/com.jsoniter.JsonIterator.readAny(JsonIterator.java:272) at com.jsoniter/com.jsoniter.JsonIterator.deserialize(JsonIterator.java:522) at com.jsoniter/com.jsoniter.JsonIterator.deserialize(JsonIterator.java:505) at com.jsoniter/com.jsoniter.TestString.test_encoding_different_than_default(TestString.java:41)
Also the test does not work for Java 17 modules as reflective access to Charset.defaultCharset is prohibited.
This pull request tries to address the issue #229
Especially with so many managed services on the Cloud, some of which we do not have any control over the initialization of the JVM, it is important to be able to control the encoding used by the library. I faced recently the problem of having one of these managed services in US-ASCII, but our Strings were encoded with UTF-8. All special characters were transformed to "?".