Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

read double value by BigDecimal #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-mangoe wants to merge 4 commits into json-iterator:master
base: master
Choose a base branch
Loading
from t-mangoe:bigdecimal
Open

read double value by BigDecimal #235

t-mangoe wants to merge 4 commits into json-iterator:master from t-mangoe:bigdecimal

Conversation

Copy link

@t-mangoe t-mangoe commented Apr 13, 2019 •
edited
Loading

I fixed code. I think this fix solves the issue #206 . If you like, please merge.

@t-mangoe t-mangoe changed the title (削除) I fixed code. I think this fix solves the issue #206 . If you like, please merge. (削除ここまで) (追記) read double value by BigDecimal (追記ここまで) Apr 13, 2019
Copy link

Codecov Report

Merging #235 into master will increase coverage by <.01%.
The diff coverage is 55.55%.

Impacted file tree graph 

@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 68.46% 68.47% +<.01% 
==========================================
 Files 107 107 
 Lines 7335 7340 +5 
 Branches 1388 1388 
==========================================
+ Hits 5022 5026 +4 
- Misses 1867 1868 +1 
 Partials 446 446
Impacted Files Coverage Δ
...ain/java/com/jsoniter/output/StreamImplString.java 53.91% <0%> (-0.48%) ⬇️
src/main/java/com/jsoniter/IterImpl.java 66.55% <100%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48a7a1...c5caefa. Read the comment docs.

Copy link
Contributor

plokhotnyuk commented Apr 13, 2019 •
edited
Loading

@t-mangoe where are tests that reproduces a problem with doubles?

and, why you have mixed it with the fix for surrogate pairs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /