Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add OpenAPI support for custom JSON:API action methods #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkoelman merged 4 commits into master from custom-jsonapi-action-methods
Sep 6, 2025

Conversation

Copy link
Member

@bkoelman bkoelman commented Sep 6, 2025

Closes #1066.

QUALITY CHECKLIST

Copy link

codecov bot commented Sep 6, 2025
edited
Loading

Codecov Report

❌ Patch coverage is 92.06897% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.05%. Comparing base (5f85f93) to head (9a81018).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...JsonApiMetadata/JsonApiEndpointMetadataProvider.cs 87.33% 11 Missing and 8 partials ⚠️
...uckle/JsonApiActionDescriptorCollectionProvider.cs 95.45% 1 Missing and 1 partial ⚠️
...adata/ActionMethods/BuiltinResourceActionMethod.cs 66.66% 1 Missing ⚠️
...re/Queries/Expressions/SparseFieldSetExpression.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #1787 +/- ##
==========================================
+ Coverage 92.01% 92.05% +0.03% 
==========================================
 Files 475 473 -2 
 Lines 14730 14818 +88 
 Branches 2339 2361 +22 
==========================================
+ Hits 13554 13640 +86 
+ Misses 772 770 -2 
- Partials 404 408 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Moves success/error status codes into metadata to support custom JSON:API action methods.
Refactored internal type hierarchy:
[Before]
OpenApiActionMethod
 CustomControllerActionMethod
 BuiltinJsonApiActionMethod { ControllerType }
 AtomicOperationsActionMethod
 JsonApiActionMethod { Endpoint }
[After]
JsonApiActionMethod { ControllerType }
 OperationsActionMethod
 ResourceActionMethod
 BuiltinResourceActionMethod { Endpoint }
 CustomResourceActionMethod { Descriptor }
@bkoelman bkoelman force-pushed the custom-jsonapi-action-methods branch from 0915cfc to 9a81018 Compare September 6, 2025 15:18
@bkoelman bkoelman marked this pull request as ready for review September 6, 2025 15:39
@bkoelman bkoelman merged commit fcc2c9b into master Sep 6, 2025
16 checks passed
@bkoelman bkoelman deleted the custom-jsonapi-action-methods branch September 6, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for mixed projects
1 participant

AltStyle によって変換されたページ (->オリジナル) /