Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes and optimizations in ToString() calls #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkoelman merged 4 commits into master from string-join
Aug 28, 2025
Merged

Fixes and optimizations in ToString() calls #1780

bkoelman merged 4 commits into master from string-join
Aug 28, 2025

Conversation

Copy link
Member

@bkoelman bkoelman commented Aug 27, 2025

Fixes and optimizations in ToString() calls. See the commit messages for details.

Fixes #1779.

QUALITY CHECKLIST

@bkoelman bkoelman changed the title (削除) String join (削除ここまで) (追記) Fixes and optimizations in ToString() calls (追記ここまで) Aug 27, 2025
Copy link

codecov bot commented Aug 28, 2025
edited
Loading

Codecov Report

❌ Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.01%. Comparing base (7f18865) to head (15ad01e).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/JsonApiDotNetCore/Queries/FieldSelection.cs 57.14% 3 Missing ⚠️
...ns/Resources/Annotations/ResourceFieldAttribute.cs 0.00% 0 Missing and 1 partial ⚠️
...piDotNetCore/Queries/Expressions/SortExpression.cs 50.00% 0 Missing and 1 partial ⚠️
...re/Queries/Expressions/SparseFieldSetExpression.cs 50.00% 0 Missing and 1 partial ⚠️
...e/Serialization/Response/ResourceObjectTreeNode.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@
## master #1780 +/- ##
==========================================
- Coverage 92.04% 92.01% -0.03% 
==========================================
 Files 475 475 
 Lines 14724 14730 +6 
 Branches 2331 2339 +8 
==========================================
+ Hits 13552 13554 +2 
- Misses 770 772 +2 
- Partials 402 404 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bkoelman bkoelman marked this pull request as ready for review August 28, 2025 00:19
@bkoelman bkoelman merged commit 5f85f93 into master Aug 28, 2025
16 checks passed
@bkoelman bkoelman deleted the string-join branch August 28, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect separator in SparseFieldSetExpression.ToFullString
1 participant

AltStyle によって変換されたページ (->オリジナル) /