-
-
Notifications
You must be signed in to change notification settings - Fork 159
Fixed crash where the OpenAPI atomic:operations discriminator key isn't unique per schema ID #1776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...'t unique per schema ID
Use case:
```c#
[Resource]
public sealed class JigsawPuzzlePicture : Identifiable<long>;
[Resource]
public sealed class JigsawPuzzle : Identifiable<long>
{
[HasOne]
public required JigsawPuzzlePicture Picture { get; set; }
}
```
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.04%. Comparing base (9277256) to head (b960dda).
Additional details and impacted files
@@ Coverage Diff @@ ## master #1776 +/- ## ========================================== - Coverage 92.04% 92.04% -0.01% ========================================== Files 475 475 Lines 14736 14724 -12 Branches 2332 2331 -1 ========================================== - Hits 13564 13552 -12 Misses 770 770 Partials 402 402
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case:
QUALITY CHECKLIST