-
-
Notifications
You must be signed in to change notification settings - Fork 90
Comments
feat: add auth.format for formatting credentials#65
Open
Phillip9587 wants to merge 1 commit intojshttp:master from
Open
feat: add auth.format for formatting credentials #65Phillip9587 wants to merge 1 commit intojshttp:master from
auth.format for formatting credentials #65Phillip9587 wants to merge 1 commit intojshttp:master from
Conversation
@Phillip9587
Phillip9587
force-pushed
the
format
branch
from
February 12, 2025 19:19
f6c3ed2 to
f33329e
Compare
throw new TypeError('argument credentials is required to have name and pass properties')
}
return 'Basic ' + Buffer.from(credentials.name + ':' + credentials.pass).toString('base64')
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should validate name doesn't contain :. From the spec:
Furthermore, a user-id containing a colon character is invalid, [...]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the
basic-authlibrary, adding a method to format credentials into a basic auth header string.