-
Notifications
You must be signed in to change notification settings - Fork 474
Open
Conversation
There is an error in line 104. (And also in line 95, but this is less important.)
The selector $("p.hidden") would find paragraphs that have a class hidden. But this is not the intention. Rather, we want to find classes that are hidden as understood by jQuery. Thus the selector should be:
$("p.hidden")
The difference ist demonstrated by the code below, with two buttons using the different selectors.
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>Demo</title>
<style>
a.test {
font-weight: bold;
}
.box { border: solid; }
.lookAtMe { background-color: aqua; }
</style>
<script src="jquery.js"></script>
</head>
<body>
<p class="box">This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked. This paragraph will fade out when clicked.</p>
<button id="TestButtonA">A: Show hidden paragraph and animate it.</button>
<button id="TestButtonB">B: Show hidden paragraph and animate it.</button>
<script>
// Clicking on the paragraph will hide it.
$( "p" ).on( "click", function() {
console.log( "click" );
$(this).hide( 800 );
});
$("#TestButton").on("click", function() {
// Fade in all hidden paragraphs; then add a style class to them (correct with animation callback)
$( "p.hidden" ).fadeIn( 750, function() {
// this = DOM element which has just finished being animated
$( this ).addClass( "lookAtMe" );
});
});
$("#TestButtonB").on("click", function() {
// Fade in all hidden paragraphs; then add a style class to them (correct with animation callback)
$( "p:hidden" ).fadeIn( 750, function() {
// this = DOM element which has just finished being animated
$( this ).addClass( "lookAtMe" );
});
});
</script>
</body>
</html>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an error in line 104. (And also in line 95, but this is less important.)
The selector $("p.hidden") would find paragraphs that have a class hidden. But this is not the intention. Rather, we want to find classes that are hidden as understood by jQuery. Thus the selector should be:
$("p.hidden")
The difference ist demonstrated by the code below, with two buttons using the different selectors.
<!doctype html>
<title>Demo</title> <style> a.test { font-weight: bold; } .box { border: solid; } .lookAtMe { background-color: aqua; }