-
Notifications
You must be signed in to change notification settings - Fork 30
Refactoring code #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Refactoring code #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...method/field,Extract class
@heli-d-bhavsar appreciated your efforts to clean up some of the very old and messy code snippets.
can we break this into smaller PRs rather than having single commit.
we have so many improvements which you have suggested. let's discuss each one in separate PR and let's merge them one by one.
here is what a single PR good to have: -
- code change limited to one file\Algorithm only.
- Respective changes in readme link (change in file name \ time-space complexity)
- if it's an indent change have it in an independent separate commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done refactoring as part of the course assignment. I have analyzed my code using designateJava. My pull request includes the following types of refactoring Refactor using Extract Method, rename Variable, Pull up method, Move method/field, Extract class #1