Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

a tiny workaround for httplib2 redirect bug #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivishnevs wants to merge 1 commit into joestump:master
base: master
Choose a base branch
Loading
from ivishnevs:httplib2-redirect-bug

Conversation

Copy link

@ivishnevs ivishnevs commented Feb 7, 2017
edited
Loading

if 'location' header is in response object, http2lib try to redirect and use self.request method with body=None argument; this behavior implies a problem like this - #203 and etc.

if response.status in [302, 303]:
 redirect_method = "GET"
 body = None <--------- 
(response, content) = self.request(
 location, method=redirect_method, body=body,
 headers=headers, redirections=redirections - 1)

Copy link

Codecov Report

Merging #214 into master will not impact coverage by -0.2%.

@@ Coverage Diff @@
## master #214 +/- ##
=========================================
- Coverage 96.05% 95.86% -0.2% 
=========================================
 Files 5 5 
 Lines 482 484 +2 
=========================================
+ Hits 463 464 +1 
- Misses 19 20 +1
Impacted Files Coverage Δ
oauth2/init.py 99.77% <50%> (-0.23%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6689960...b8bf881. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /