-
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the WebAssembly UI and documentation to surface a new Android native app alongside the existing Windows app, and includes a few supporting build/CI adjustments.
Changes:
- Add Google Play Store links/badges in the app loading footer and README, plus a new
docs/native-apps.mdlanding page. - Introduce
IAppHostEnvironment.HasHardwareKeyboardAsync()and gate Monaco editor focusing behavior behind it. - Improve index.html generation timing/robustness in MSBuild and add a CI build job that validates building without the compiler toolset compilers.
Reviewed changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WebAssembly/WebAssembly.csproj | Adds Google Play link (and icon) to the generated index.html loading footer. |
| src/WebAssembly/Program.cs | Updates "desktop app" link metadata and adds a stub HasHardwareKeyboardAsync() implementation. |
| src/Directory.Build.targets | Expands default RuntimeIdentifiers to include Android RIDs when none are specified. |
| src/App/Lab/Settings.razor | Simplifies desktop/native app link click handler wiring for the Settings UI. |
| src/App/Lab/Page.razor | Avoids auto-focusing editors unless a hardware keyboard is present. |
| src/App/App.cs | Extends IAppHostEnvironment and adjusts DesktopAppLink.OnClick type. |
| README.md | Adds Android Play Store link and badge next to the Windows badge. |
| eng/IndexHtmlGeneration.targets | Runs index.html generation earlier and ensures output directory exists. |
| docs/native-apps.md | New documentation page listing native apps. |
| Directory.Packages.props | Removes the JitInspect package version entry. |
| .github/workflows/build.yml | Adds CI job to build with DotNetLabUseCompilerToolset=false and uploads binlog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.