-
Notifications
You must be signed in to change notification settings - Fork 683
Implement jerry_port_path_normalize in a more reliable way #5198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lygstate
lygstate
force-pushed
the
normalize-path
branch
2 times, most recently
from
December 11, 2024 11:51
9714443 to
2223363
Compare
@LaszloLango
LaszloLango
requested review from
ossy-szeged,
zherczeg and
robertsipka
December 12, 2024 16:58
@lygstate
lygstate
force-pushed
the
normalize-path
branch
from
December 17, 2024 20:59
2223363 to
ca387ba
Compare
Replace jerry_port_path_normalize,jerry_port_path_free,jerry_port_path_base with jerry_port_path_style,jerry_port_get_cwd Partially fixes jerryscript-project#4979 Closes: jerryscript-project#4983 JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
@lygstate
lygstate
force-pushed
the
normalize-path
branch
from
December 19, 2024 08:58
ca387ba to
f368ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace jerry_port_path_normalize,jerry_port_path_free,jerry_port_path_base with jerry_port_path_style,jerry_port_get_cwd
Partially fixes feature, strlen are rarely called in jerry-core and jerry-ext, we can remove all the usage of strlen #4979
Closes: on unix, realpath are can failed when the path not exist #4983
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
now fore memory-restricted system, excluding es-module will reduce code size
The port api is reduced to simpler
jerry_port_path_stylejerry_port_get_cwd