Skip to content

Navigation Menu

Sign in
Sign up

JENKINS-76080 - Validate signatures fix when secrets are not set - #441

Draft
HybridProgrammer wants to merge 5 commits into
jenkinsci:master from
HybridProgrammer:fix/jh-JENKINS-76080-no-secret
Draft

JENKINS-76080 - Validate signatures fix when secrets are not set #441
HybridProgrammer wants to merge 5 commits into
jenkinsci:master from
HybridProgrammer:fix/jh-JENKINS-76080-no-secret

Conversation

@HybridProgrammer

@HybridProgrammer HybridProgrammer commented Sep 13, 2025
edited by KostyaSha
Loading

Copy link
Copy Markdown
Contributor

Created tests with @Issue("JENKINS-76080") annotation to better understand the behavior described by users. I was able to recreate the issue when a shared secret config was created in jenkins but no share secret jenkins credential was created or selected. When the payload is sent to /github-webhook/ endpoint without Github's X-Hub-Signature headers the HTTP 400 error is returned.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

This change is Reviewable

@HybridProgrammer HybridProgrammer changed the title (削除) JENKINS-76080 - Validate signatures without secret when not configured (削除ここまで) (追記) JENKINS-76080 - Validate signatures fix when secrets are not set (追記ここまで) Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /