[JENKINS-24076] Add a configuration option for stable build comparison - #24

Open

iwonbigbro wants to merge 1 commit into

jenkinsci:master from

iwonbigbro:master

Open

[JENKINS-24076] Add a configuration option for stable build comparison #24
iwonbigbro wants to merge 1 commit into
jenkinsci:master from
iwonbigbro:master

Conversation

@iwonbigbro

@iwonbigbro iwonbigbro commented Sep 18, 2014

Copy link

Copy Markdown

Add a configuration option for Cppcheck to compare results against a stable build rather than the last
build.

@iwonbigbro


 [JENKINS-24076] Add a configuration option that allows you to force

d639413

Cppcheck to compare results against a stable build rather than the last
build.

@jenkinsadmin

jenkinsadmin commented Sep 18, 2014

Copy link

Copy Markdown

Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@mixalturek

mixalturek commented Sep 19, 2014

Copy link

Copy Markdown

Contributor

I will merge it a release new version on Sunday (hopefully), thanks.
M.

[画像:mixalturek]

mixalturek reviewed

Sep 21, 2014

View reviewed changes

src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java

@mixalturek mixalturek Sep 21, 2014

Copy link

Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stableBuild would be stored to build.xml together with all non-transient fields now. This data file should contain only data from the particular build, stableBuild is global configuration flag.

<org.jenkinsci.plugins.cppcheck.CppcheckBuildAction>
 <owner class="build" reference="../../.."/>
 <result>
 <owner class="build" reference="../../../.."/>
 <statistics>
 <errorCount>0</errorCount>
 <warningCount>1</warningCount>
 <styleCount>22</styleCount>
 <performanceCount>2</performanceCount>
 <informationCount>1</informationCount>
 <noCategoryCount>0</noCategoryCount>
 <portabilityCount>0</portabilityCount>
 <versions>
 <string>1.61</string>
 </versions>
 </statistics>
 <stableBuild>false</stableBuild> <!-- *** HERE *** -->
 </result>
 <healthReportPercentage>-1</healthReportPercentage>
</org.jenkinsci.plugins.cppcheck.CppcheckBuildAction>

@iwonbigbro

iwonbigbro commented Nov 7, 2014

Copy link

Copy Markdown

Author

I might be able to get these changes in this weekend. If I have time, I'll also look into the delta issue too. What is the mail group I need to email to get added as a maintainer? Thanks