src/packages/popup/popup.taro.tsx (1)

171-174: 放宽关闭条件判定,避免"未显式返回值不关闭"

当前写法要求 onCloseIconClick 显式返回 truthy 才会关闭;若用户回调未返回值(undefined),将导致不关闭,和直觉不符。建议改为"非 false 即关闭",并使用可选链以防御空回调。

可按以下方式调整:

 const handleCloseIconClick = (e: ITouchEvent) => {
 e.stopPropagation()
- onCloseIconClick(e) && close()
+ if (onCloseIconClick?.(e) !== false) close()
 }

src/packages/cascader/cascader.taro.tsx (2)

165-176: 避免同名变量"parent"遮蔽,提升可读性与可维护性

回调内部的 const parent = await promise 会遮蔽外层 parent,阅读和调试都容易混淆。建议重命名为 node 并相应替换,保持语义清晰。

- await innerValue.reduce(async (promise: Promise<any>, val, key) => {
- const pane = await onLoad({ value: val }, key)
- const parent = await promise
- if (parent) parent.children = pane
- if (key === innerValue.length - 1) {
- return Promise.resolve(parent)
- }
- if (pane) {
- const node = pane.find((p) => p.value === val)
- return Promise.resolve(node)
- }
- }, Promise.resolve(parent))
+ await innerValue.reduce(async (promise: Promise<any>, val, key) => {
+ const pane = await onLoad({ value: val }, key)
+ const node = await promise
+ if (node) node.children = pane
+ if (key === innerValue.length - 1) {
+ return Promise.resolve(node)
+ }
+ if (pane) {
+ const next = pane.find((p) => p.value === val)
+ return Promise.resolve(next)
+ }
+ }, Promise.resolve(parent))

---

185-186: 避免陈旧闭包与竞态:完善依赖并添加"活性"守卫

该 useEffect 只依赖 lazy,但内部使用了 innerValue 与 onLoad;当外部受控值或加载函数变化时不会重新拉取,且并发加载可能造成越界更新。建议将依赖改为 [lazy, innerValue, onLoad],并用 active 标记防止卸载后的 setInnerOptions。

- useEffect(() => {
- const load = async () => {
+ useEffect(() => {
+ let active = true
+ const load = async () => {
 const parent = { children: [] }
 try {
 await innerValue.reduce(async (promise: Promise<any>, val, key) => {
 const pane = await onLoad({ value: val }, key)
 const parent = await promise
 if (parent) parent.children = pane
 if (key === innerValue.length - 1) {
 return Promise.resolve(parent)
 }
 if (pane) {
 const node = pane.find((p) => p.value === val)
 return Promise.resolve(node)
 }
 }, Promise.resolve(parent))
 
- // 如果需要处理最终结果,可以在这里使用 last
- setInnerOptions(parent.children)
+ if (active) setInnerOptions(parent.children)
 } catch (error) {
 console.error('Error loading data:', error)
 }
 }
 
- if (lazy) load()
- }, [lazy])
+ if (lazy) load()
+ return () => {
+ active = false
+ }
+ }, [lazy, innerValue, onLoad])

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.